Skip to content

[Source Gen] Refactor to walk dependent assemblies#1896

Merged
satvu merged 7 commits intomainfrom
satvu/refactor-walk-dependencies
Sep 18, 2023
Merged

[Source Gen] Refactor to walk dependent assemblies#1896
satvu merged 7 commits intomainfrom
satvu/refactor-walk-dependencies

Conversation

@satvu
Copy link
Copy Markdown
Member

@satvu satvu commented Sep 11, 2023

Issue describing the changes in this PR

resolves #1160

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@satvu satvu requested review from jviau and kshyju September 11, 2023 21:07
@satvu satvu requested a review from fabiocav September 12, 2023 17:46
jviau
jviau reviewed Sep 13, 2023
View reviewed changes
Comment thread sdk/Sdk.Generators/FunctionMetadataProviderGenerator/FunctionMetadataProviderGenerator.cs Outdated
Comment thread sdk/Sdk.Generators/FunctionMetadataProviderGenerator/FunctionMetadataProviderGenerator.cs Outdated
Comment thread sdk/Sdk.Generators/FunctionsUtil.cs Outdated
Comment thread sdk/Sdk.Generators/FunctionsUtil.cs Outdated
Comment thread test/Sdk.Generator.Tests/FunctionMetadataProviderGeneratorTests/DependentAssemblyTest.cs Outdated
kshyju
kshyju reviewed Sep 14, 2023
View reviewed changes
Comment thread test/DependentAssemblyWithFunctions/DependentAssemblyWithFunctions.csproj Outdated
kshyju
kshyju reviewed Sep 14, 2023
View reviewed changes
Comment thread test/DependentAssemblyWithFunctions/Class1.cs Outdated
kshyju
kshyju reviewed Sep 14, 2023
View reviewed changes
Comment thread test/DependentAssemblyWithFunctions/Class1.cs Outdated
kshyju
kshyju reviewed Sep 14, 2023
View reviewed changes
Comment thread sdk/Sdk.Generators/FunctionsUtil.cs Outdated
kshyju
kshyju reviewed Sep 14, 2023
View reviewed changes
Comment thread sdk/Sdk.Generators/FunctionsUtil.cs
@satvu satvu merged commit fec76f4 into main Sep 18, 2023
@satvu satvu deleted the satvu/refactor-walk-dependencies branch September 18, 2023 17:41
@mnelsonwhite mnelsonwhite mentioned this pull request Dec 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kshyju kshyju kshyju approved these changes

@jviau jviau jviau approved these changes

@fabiocav fabiocav Awaiting requested review from fabiocav

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Generate function metadata for functions from dependent assemblies

3 participants

@satvu @kshyju @jviau